Add Contravariant Observer and Subscriber#759
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 90.45% 90.46% +<.01%
==========================================
Files 419 419
Lines 11879 11908 +29
Branches 2187 2183 -4
==========================================
+ Hits 10745 10772 +27
- Misses 1134 1136 +2 |
alexandru
reviewed
Nov 6, 2018
Avasil
commented
Nov 6, 2018
|
|
||
| private final class ContravariantObserver[A, B](source: Observer[A])(f: B => A) extends Observer[B] { | ||
| // For protecting the contract | ||
| private[this] var isDone = false |
Collaborator
Author
There was a problem hiding this comment.
@alexandru What's the rule whether we need this protection or not? Sometimes I see this sometimes I don't
Member
|
@Avasil so |
Collaborator
Author
|
@alexandru Would you say we can add instances without testing laws in this case or drop the idea? I guess we could also add the |
Member
|
Yes, add the |
…riberProfunctor # Conflicts: # monix-reactive/shared/src/main/scala/monix/reactive/instances/CatsContravariantForObserver.scala # monix-reactive/shared/src/main/scala/monix/reactive/instances/CatsContravariantForSubscriber.scala
Collaborator
Author
|
@alexandru Done! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #748
TODO:
To test laws we need to implement
EqandGenforObserver/Subscriber. So far I don't have any ideas that make sense so I'm issuing PR in case someone does