Update intervalWithFixedDelay scaladoc#798
Merged
Merged
Conversation
Avasil
commented
Dec 18, 2018
| * delay, after which it emits incremented numbers spaced by the | ||
| * (longs) spaced by a given time interval. Starts from 0 with `initialDelay`, | ||
| * after which it emits incremented numbers spaced by the | ||
| * `period` of time. The given `period` of time acts as a fixed |
Collaborator
Author
There was a problem hiding this comment.
I feel like period should be delay (name of the parameter) but I'm not sure
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 85.08% 85.04% -0.04%
==========================================
Files 426 426
Lines 13096 13096
Branches 2341 2341
==========================================
- Hits 11143 11138 -5
- Misses 1953 1958 +5 |
alexandru
pushed a commit
that referenced
this pull request
Jan 12, 2019
* Acquire lock per subscription instead of observable-wide lock * Update cats-effect, cats-effect-laws to 1.1.0 (#788) * Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26 (#785) * Scala 2.12.8 (#797) * Update intervalWithFixedDelay scaladoc (#798) * Update intervalWithFixedDelay scaladoc * Update Observable.scala * fix scalacOptions (#796) * fix scalacOptions "-Ywarn-unused-import" removed since Scala 2.13.x scala/scala@ad25805 * fix scalacOptions for Scala 2.13.x some options removed since Scala 2.13.x * Eagerly null out dequeued elements in ChunkedArrayQueue (#803) * Observable buffers refactoring (#801) * Refactoring of Observable buffers and OverflowStrategy * Observable.create change signature * Fix Mima reports * Small adjustments * Add forgotten default value for maxBatch * Make OverflowStrategy.Unbounded final * Fix Mima * Fix #787: encapsulate local ctx on task execution (#802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one mistake and adds new sentence that is also present in
intervalAtFixedRate