Rename Task.forkAndForget to Task.startAndForget#972
Merged
Conversation
Avasil
commented
Aug 2, 2019
| final def void: Task[Unit] = | ||
| this.map(_ => ()) | ||
|
|
||
| // Deprecation directly in `Task` to avoid binary breakage just before the release |
Collaborator
Author
There was a problem hiding this comment.
I was getting DirectMissingMethodProblem if I put it in Deprecations syntax so wanted to be safe
Member
|
👍 |
Member
|
@Avasil from a code organization perspective, I don't like leaving One idea would be to create a new trait for deprecated methods in the |
Collaborator
Author
mdedetrich
pushed a commit
to mdedetrich/monix
that referenced
this pull request
Mar 28, 2020
* Rename `Task.forkAndForget` to `Task.startAndForget` * Move deprecation to Task itself * Move forkAndForget to separate trait * Remove extra line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877