Fix #991: Local and TaskRunLoop#993
Merged
Merged
Conversation
Member
Author
|
Released hash version for testing: |
Avasil
reviewed
Aug 28, 2019
| // Transporting the current context if localContextPropagation == true. | ||
| Local.bind(savedLocals) { | ||
| var prevLocals: Local.Context = null | ||
| if (savedLocals != null) { |
Collaborator
There was a problem hiding this comment.
Is it needed if there is already a null check in Local.bind? Or is it just to inline?
Member
Author
There was a problem hiding this comment.
I'm doing this for inlining, since Local.bind is no longer a macro and I don't want to have the penalty of that call in case locals are not enabled.
Avasil
approved these changes
Aug 29, 2019
mdedetrich
pushed a commit
to mdedetrich/monix
that referenced
this pull request
Mar 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #991 for details.