fix(release script): not updating root package.json version + not supporting some shells (@NadAlaba)
#5825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I would change it to only update the root package.json and remove the version numbes from others. |
Miodec
reviewed
Aug 28, 2024
| prs, | ||
| prs: prs || [], | ||
| body: body || "", | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Yeah it's tested.
It's not really needed (as far as my tests went), but I added it just for consistency with usernames.
If you can tell me what errors were you avoiding on 0a23897, maybe we can remove it from both usernames and prs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating the version, the script is getting current version from root
package.json, but updatingrelease/package.json, so rootpackage.jsonnever gets updated and minor will always be zero.Chosen solution was to get version from root, but update both.
Other possible solution is to not use version in
release/package.jsonat all (i.e, get and set version in root only).[EDIT]
Solution changed to removing version from all
package.jsonother than root one, and only get and update it in root.Change single quotes in
nodemon --exec '...'to double quotes.Changes in
buildChangelog.getLog()are because some shells don't support evaluating subexpressions in$(...).Change root
package.jsonversion to current version.In commit titles, trailing parenthesis that are not usernames or PR numbers are being considered PRs. So now usernames get matched when they start with
@and PRs when they start with#.