chore(PR labeler): fix workflow having read access only, when triggered from forks (@NadAlaba) #5842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
requested changes
Sep 2, 2024
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous automatic PR labeler doesn't work when triggered from forks because workflows triggered from forks by the events
pull_requestandpull_request_reviewhave read access only, and can't write to PRs (change labels).This is an attempt to solve this issue by splitting the workflow in 2:
One with read access only, that gets triggered by those events, and when completed another workflow would run with write access that would perform the change.
I added everything I could think of to the list of conditions to update the labels (because removing conditions later is easier than going back to the docs and adding more conditions). You may need to go over this list and remove what you deem unnecessary.