Skip to content

fix(caret): getting last letter top in long multiline words (@NadAlaba) #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miodec merged 3 commits into from
Sep 6, 2024
Merged

fix(caret): getting last letter top in long multiline words (@NadAlaba) #5856

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc7b3ce
fix(caret): getting last letter top in long multiline words (@NadAlaba)
nadalaba Sep 6, 2024
5c1c4a7
no need to check for invisible extra letters
nadalaba Sep 6, 2024
e7b6801
update comment
nadalaba Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/ts/test/caret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,15 @@ export async function updatePosition(noAnim = false): Promise<void> {
const isLanguageRightToLeft = currentLanguage.rightToLeft;

// in blind mode, and hide extra letters, extra letters have zero offsets
// offsetTop and offsetHeight is the same for all visible letters
// offsetHeight is the same for all visible letters
// so is offsetTop (for same line letters)
const letterHeight =
currentLetter?.offsetHeight ||
lastWordLetter?.offsetHeight ||
Config.fontSize * Numbers.convertRemToPixels(1);

const letterPosTop =
currentLetter?.offsetTop || lastWordLetter?.offsetTop || 0;
currentLetter?.offsetTop ?? lastWordLetter?.offsetTop ?? 0;
const diff = letterHeight - caret.offsetHeight;
let newTop = activeWordEl.offsetTop + letterPosTop + diff / 2;
if (Config.caretStyle === "underline") {
Expand Down