Skip to content

impr: move configuration checks to contracts (@fehmer) #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 6 commits into from
Sep 11, 2024
Merged

impr: move configuration checks to contracts (@fehmer) #5851

Miodec merged 6 commits into from
Sep 11, 2024

Conversation

@fehmer
Copy link
Member

@fehmer fehmer commented Sep 5, 2024 •
edited
Loading

No description provided.

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Sep 5, 2024
@fehmer fehmer changed the base branch from master to feature/refactor-role-permissions September 5, 2024 10:59
@monkeytypegeorge monkeytypegeorge removed the frontend User interface or web stuff label Sep 5, 2024
@fehmer fehmer force-pushed the feature/refactor-role-permissions branch 3 times, most recently from ce0f7db to 97b18e1 Compare September 9, 2024 09:05
Base automatically changed from feature/refactor-role-permissions to master September 10, 2024 09:36
@fehmer fehmer force-pushed the feature/refactor-configuration-requirements branch from 3f07c81 to f282db1 Compare September 10, 2024 09:55
@fehmer fehmer added the force-ci Force CI to run on draft PRs label Sep 10, 2024
@fehmer fehmer force-pushed the feature/refactor-configuration-requirements branch from f282db1 to 140337a Compare September 10, 2024 09:58
@fehmer fehmer marked this pull request as ready for review September 10, 2024 11:46
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Sep 10, 2024
Miodec
Miodec approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit b315836 into master Sep 11, 2024
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Sep 11, 2024
@Miodec Miodec deleted the feature/refactor-configuration-requirements branch September 11, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec approved these changes

Assignees

No one assigned

Labels

backend Server stuff force-ci Force CI to run on draft PRs packages Changes in local packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fehmer @Miodec @monkeytypegeorge