Skip to content

Conversation

@xaskii
Copy link
Contributor

@xaskii xaskii commented Oct 6, 2024

Description

Adds <Ctrl-p> and <Ctrl-n> binds to the command-line. These are from Emacs, but you can navigate up and down menus all over macOS and its apps with these keybinds.

Relevant PRs

Refactor that removed the binds: #5180
adding "vim keybinds": #4019

Confirmed working on macOS (safari, firefox, and chrome). On windows, <Ctrl-n>: opening a new window takes priority, but that's expected behaviour.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes issue discussed in discord.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Oct 6, 2024
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 0a8aac2 into monkeytypegame:master Oct 7, 2024
@xaskii xaskii deleted the emacs/macos-binds-to-commandline branch October 7, 2024 12:01
@xaskii
Copy link
Contributor Author

xaskii commented Oct 7, 2024

Thanks

Thanks for maintaining this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants