fix(key tips): "off" shown instead of "tab + enter" when quick restart is disabled (@mrtianjin829) #6036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like an oversight by the last editor of this code. It should say "tab + enter" instead of "off" or "no key bound". Could you modify your PR? |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
Contributor
Author
I have modified the PR so that it says "tab + enter" instead of "off", but when the keybind isnt changed, by default, it just says "off". |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
Member
|
Made some minor fixes and reran prettier. Thanks for your PR. |
Contributor
Author
|
Welcome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People will get confused if they see "off" as the quick restart key bind, so if the quick restart keybind is not bound, instead it will show
(No key binded)instead.