feat: leaderboards remake, weekly xp leaderboards (@miodec) #6250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
reviewed
Feb 11, 2025
| const PaginationQuerySchema = z.object({ | ||
| skip: z.number().int().nonnegative().optional(), | ||
| limit: z.number().int().nonnegative().max(50).optional(), | ||
| page: z.number().int().nonnegative().optional(), |
Member
There was a problem hiding this comment.
we could add page:...default(0) and pageSize:...default(50) here. This would add the default values to the api documentation:
Member
Author
There was a problem hiding this comment.
Does it fill in the data if undefined?
add default to schemas
Miodec
added a commit
that referenced
this pull request
Feb 12, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brrrrrr
Checks
_list.json,_groups.jsonand addlanguages.json?Closes #4775