Skip to content

impr(quotes): add English quotes (@thedev0ps) #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 2 commits into from
Feb 19, 2025
Merged

impr(quotes): add English quotes (@thedev0ps) #6271

Miodec merged 2 commits into from
Feb 19, 2025

Conversation

@thedev0ps
Copy link
Contributor

@thedev0ps thedev0ps commented Feb 16, 2025

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 16, 2025
Miodec
Miodec requested changes Feb 19, 2025
View reviewed changes
frontend/static/quotes/english.json Outdated
Comment on lines 38588 to 38589
"text": "Man is the most insane species. He worships an invisible God and destroys a visible Nature. Unaware that this Nature he's destroying is this God he's worshiping.",
"source": "Hubert Reeves",
Copy link
Member

@Miodec Miodec Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove/replace anything that might mention religion as it relaly gets both sides riled up.

Copy link
Contributor Author

@thedev0ps thedev0ps Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Religious quotes have been removed and upadated!

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 19, 2025
@thedev0ps
Copy link
Contributor Author

thedev0ps commented Feb 19, 2025 via email

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 19, 2025
@Miodec Miodec merged commit 14d423e into monkeytypegame:master Feb 19, 2025
13 checks passed
@Miodec
Copy link
Member

Miodec commented Feb 19, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec requested changes

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thedev0ps @Miodec @monkeytypegeorge