Skip to content

fix: past leaderboard not fetching the users rank (@fehmer) #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 4 commits into from
Feb 21, 2025
Merged

fix: past leaderboard not fetching the users rank (@fehmer) #6289

Miodec merged 4 commits into from
Feb 21, 2025

Conversation

@fehmer
Copy link
Member

@fehmer fehmer commented Feb 21, 2025 •
edited
Loading

Show the users ranking for the last day on the daily and for the last week on the weekly leaderboard correctly.

  • Fix request query schema for the daily rank having pagination
  • Fix request query schema for the weekly rank missing the weeksBefore parameter
  • Fix frontend to include the daysBefore or weeksBefore parameter on rank calls

@monkeytypegeorge monkeytypegeorge added backend Server stuff packages Changes in local packages labels Feb 21, 2025
@fehmer fehmer added force-ci Force CI to run on draft PRs backend Server stuff packages Changes in local packages and removed backend Server stuff packages Changes in local packages labels Feb 21, 2025
@fehmer fehmer force-pushed the feature/fix-leaderboard-rank branch from f965f1f to dc08366 Compare February 21, 2025 10:19
fehmer
fehmer commented Feb 21, 2025
View reviewed changes
backend/src/api/controllers/leaderboard.ts
}

function getDailyLeaderboardWithError(
{ language, mode, mode2, daysBefore }: GetDailyLeaderboardRankQuery,
Copy link
Member Author

@fehmer fehmer Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagination is not supported by this method, using DailyLeaderboardQuery without pagination

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Feb 21, 2025
@fehmer fehmer marked this pull request as ready for review February 21, 2025 11:11
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Feb 21, 2025
Miodec
Miodec approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 8a41cce into master Feb 21, 2025
11 checks passed
@Miodec Miodec deleted the feature/fix-leaderboard-rank branch February 21, 2025 15:52
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec approved these changes

Assignees

No one assigned

Labels

backend Server stuff force-ci Force CI to run on draft PRs frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fehmer @Miodec @monkeytypegeorge