feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) #6663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15b5376 to
3a1dcbd
Compare
byseif21
reviewed
Jun 25, 2025
frontend/src/ts/pages/settings.ts
Outdated
| ).on("click", () => { | ||
| ).on("click", async () => { | ||
| if (Config.customBackground === "localBackgroundFile") { | ||
| await FileStorage.deleteFile("localBackgroundFile"); |
Contributor
There was a problem hiding this comment.
just a small thing when deleting the local background, the input box will still show the previous text. would it be good to add
$(".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input.input").val("");or something to clear it since it's not reusable like the url ? if you understand what i mean
Contributor
|
hey @fehmer thanks and yah very nice , just don't we forget to update the setting description too. or you think the aria-label enough ? |
Contributor
|
also didn't we still need to add a file size check before storing? |
Member
Author
|
hi @byseif21 , thanks for your comments. I updated the description and icon to match the same as "open file" in custom text settings. An upload icon might be confusing. I don't think we need a file size check, the limit for idb is like 20gig or 10% of the users disc space, so we should be fine. |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
fehmer
commented
Jun 27, 2025
### Description This PR adds language support for the ABAP programming language. It adds code_abap with the 200 most used ABAP keywords and code_abap_1k with all ABAP keywords from the current ABAP language version. ### Checks - [x] Adding a language? - Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) - [x] Add language to `packages/schemas/src/languages.ts` - [x] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` - [x] Add language json file to `frontend/static/languages` - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
@byseif21) (#6581) ### Description When (changing / adding or removing themes from favorite ) via command line or from the current theme button "in page e.g test page" and then navigating to Settings > Themes, the UI does not immediately reflect the current theme changes . The user has to manually refresh the page to see these changes. **Now** UI automatically refreshes to reflect the current theme selection and favorites without requiring a manual page refresh. - Added refreshThemeUI function in theme-picker.ts that updates all theme-related UI components - Called this refresh function in the settings page's beforeShow lifecycle hook to ensure the theme UI is always up-to-date when the page is displayed. **FOR TESTING BEFORE & AFTER:** keep changing themes then navigate to the settings and check and keep doing those things again to verify that the active theme and favorites update. --------- Co-authored-by: Miodec <jack@monkeytype.com>
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to use a local file as custom background without uploading it to the server.
Based on @byseif21 work in #6630, thanks!