impr(test-screenshot): Show download screenshot button when holding shift on result page (@raaid3) #6673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more specific dom query for performance
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if you shift clicked on the
copy screenshotbutton, you could download a screenshot. But many users probably don't know about this because it's not mentioned anywhere on the result page and there are no visual indicators hinting at there being such a feature.So I added a "(shift click to download)" message to the
aria-labelof the#saveScreenshotbutton. I also added the ability for the icon inside the button to switch tofa-downloadwhen shift is held as a visual indicator that clicking the button would download a screenshot.