Skip to content

impr(leaderboard): daily mode/language buttons based on backend configuration (@fehmer) #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 22 commits into from
Jul 14, 2025
Merged

impr(leaderboard): daily mode/language buttons based on backend configuration (@fehmer) #6713

Miodec merged 22 commits into from
Jul 14, 2025

Conversation

@fehmer
Copy link
Member

@fehmer fehmer commented Jul 9, 2025

No description provided.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jul 9, 2025
@fehmer fehmer force-pushed the feature/leaderboard-nav-from-configuration branch from d00e130 to 6ff0da4 Compare July 10, 2025 09:15
@fehmer fehmer changed the title impr(leaderboard): use mode/language buttons based on backend configuration (@fehmer) impr(leaderboard): daily mode/language buttons based on backend configuration (@fehmer) Jul 10, 2025
@fehmer fehmer marked this pull request as ready for review July 10, 2025 09:21
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jul 10, 2025
@monkeytypegeorge monkeytypegeorge added the backend Server stuff label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Jul 11, 2025
@monkeytypegeorge monkeytypegeorge added the packages Changes in local packages label Jul 11, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
Miodec added 3 commits July 11, 2025 23:18
@Miodec
split secondary buttons into explicit mode and language buttons
ebf5485 
merge side button update into one function that calls 3, specialised ones
remove commented code
not sure if aftershow update is needed, commenting out for now
@Miodec
rename buttons to sideButtons
120a5ea
@Miodec
fix language buttons sticking around too much
98f3467
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 11, 2025
@fehmer fehmer marked this pull request as draft July 13, 2025 08:29
@fehmer fehmer marked this pull request as ready for review July 13, 2025 09:25
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jul 13, 2025
Miodec
Miodec approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit a4de8df into master Jul 14, 2025
12 checks passed
@Miodec Miodec deleted the feature/leaderboard-nav-from-configuration branch July 14, 2025 13:32
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec approved these changes

Assignees

No one assigned

Labels

backend Server stuff frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fehmer @Miodec @monkeytypegeorge