Skip to content

fix(friends): change "max streak" tooltip to "longest streak" (@ashiqr-dev) #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 4 commits into from
Dec 4, 2025
Merged

fix(friends): change "max streak" tooltip to "longest streak" (@ashiqr-dev) #7165

Miodec merged 4 commits into from
Dec 4, 2025

Conversation

@ashiqr-dev
Copy link
Contributor

@ashiqr-dev ashiqr-dev commented Nov 28, 2025 •
edited
Loading

Description

Changed friends tooltip message from "max streak" to "longest streak". Please close the PR if this was intentional wording.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
    • Add some screenshot of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the themes documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #7127

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 28, 2025
Copilot AI review requested due to automatic review settings December 3, 2025 00:12
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 3, 2025
Copilot AI reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves terminology consistency by changing the tooltip text from "max streak" to "longest streak" in the friends page. This aligns the friends page tooltip with the terminology already used in the profile page (which displays "Longest streak:").

  • Changed tooltip label from "max streak" to "longest streak" for better consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Miodec Miodec merged commit 6475b42 into monkeytypegame:master Dec 4, 2025
16 checks passed
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Dec 4, 2025
@ashiqr-dev ashiqr-dev deleted the fix_friends_streak_text branch December 4, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Miodec Miodec Miodec approved these changes

Assignees

No one assigned

Labels

frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

change "max streak" to "longest streak" in friends

3 participants

@ashiqr-dev @Miodec @monkeytypegeorge