Changing shortcut App ID broke protontricks #898

In the past, protontricks was working for me with the GOG Galaxy launcher under its own prefix. However, after recently running the NSL script, it seems that the GOG Galaxy launcher shortcut in Steam was updated and got a new App ID, and this change to the shortcut broke protontricks.

There is a symlink that connects the folder "GogGalaxyLauncher" to the folder named after the App ID where the actual contents resides. The symlink "GogGalaxyLauncher" is used in the steam shortcut "Target", "Start In" and "Launch Options" configuration, so a change in the App ID does not cause the shortcut to stop working. This is because the "GogGalaxyLauncher" points to the correct folder with all the contents, the folder named after the original App ID.

It seems that after recently launching the NSL script in desktop mode, the GOG Galaxy Launcher shortcut in Steam received a new App ID. This broke protontricks because it looks for the actual content in the folder matching the name of the shortcut's App ID, and seemingly ignores the "Target", "Start In", and "Launch Options".

Inspecting the file system, I could see that the "GogGalaxyLauncher" symlink was pointing to another folder with all the contents in it. That folder appeared to be named after the original App ID. When running protontricks in verbose mode, I noticed that the folder and App ID it reported was different, and it said that there was no Proton app there. Having a look at the folder in the file system, it was a new folder, and it was actually empty.

I deleted the new empty folder and created a new symlink in its place pointing to the original folder. The same folder that the "GogGalaxyLauncher" symlink points to. That got protontricks working again.

I do not know how Steam decides what the App ID is for a shortcut. However, if NSL is updating a Steam shortcut and the App ID changes, the NSL script could automatically create a symlink to the original App ID in order to maintain compatability with protontricks.