Skip to content

Commit be8c54e

Browse files
committed
Revert "Bug 2036400 - Initialize uninitialized scalar fields in layout to fix Coverity uninitialized-scalar defects r=layout-reviewers,emilio" for causing build bustages in SVGFilterInstance.h
This reverts commit 8b52e50.
1 parent ea7ebd9 commit be8c54e

12 files changed

Lines changed: 42 additions & 37 deletions

‎layout/base/nsRefreshDriver.cpp‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1420,7 +1420,19 @@ nsRefreshDriver::nsRefreshDriver(nsPresContext* aPresContext)
14201420
mFreezeCount(0),
14211421
mThrottledFrameRequestInterval(
14221422
TimeDuration::FromMilliseconds(GetThrottledTimerInterval())),
1423-
mMinRecomputeVisibilityInterval(GetMinRecomputeVisibilityInterval()) {
1423+
mMinRecomputeVisibilityInterval(GetMinRecomputeVisibilityInterval()),
1424+
mThrottled(false),
1425+
mNeedToRecomputeVisibility(false),
1426+
mTestControllingRefreshes(false),
1427+
mInRefresh(false),
1428+
mWaitingForTransaction(false),
1429+
mSkippedPaints(false),
1430+
mResizeSuppressed(false),
1431+
mInNormalTick(false),
1432+
mAttemptedExtraTickSinceLastVsync(false),
1433+
mHasExceededAfterLoadTickPeriod(false),
1434+
mHasImageAnimations(false),
1435+
mHasStartedTimerAtLeastOnce(false) {
14241436
MOZ_ASSERT(NS_IsMainThread());
14251437
MOZ_ASSERT(mPresContext,
14261438
"Need a pres context to tell us to call Disconnect() later "

‎layout/base/nsRefreshDriver.h‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -502,40 +502,40 @@ class nsRefreshDriver final : public mozilla::layers::TransactionIdAllocator,
502502

503503
mozilla::UniquePtr<mozilla::ProfileChunkedBuffer> mPaintCause;
504504

505-
bool mThrottled : 1 = false;
506-
bool mNeedToRecomputeVisibility : 1 = false;
507-
bool mTestControllingRefreshes : 1 = false;
508-
bool mInRefresh : 1 = false;
505+
bool mThrottled : 1;
506+
bool mNeedToRecomputeVisibility : 1;
507+
bool mTestControllingRefreshes : 1;
508+
bool mInRefresh : 1;
509509

510510
// True if the refresh driver is suspended waiting for transaction
511511
// id's to be returned and shouldn't do any work during Tick().
512-
bool mWaitingForTransaction : 1 = false;
512+
bool mWaitingForTransaction : 1;
513513
// True if Tick() was skipped because of mWaitingForTransaction and
514514
// we should schedule a new Tick immediately when resumed instead
515515
// of waiting until the next interval.
516-
bool mSkippedPaints : 1 = false;
516+
bool mSkippedPaints : 1;
517517

518518
// True if view managers should delay any resize request until the
519519
// next tick by the refresh driver. This flag will be reset at the
520520
// start of every tick.
521-
bool mResizeSuppressed : 1 = false;
521+
bool mResizeSuppressed : 1;
522522

523523
// True if we may need to run any frame callback.
524-
bool mNeedToRunFrameRequestCallbacks : 1 = false;
524+
bool mNeedToRunFrameRequestCallbacks : 1;
525525

526526
// True if we're currently within the scope of Tick() handling a normal
527527
// (timer-driven) tick.
528-
bool mInNormalTick : 1 = false;
528+
bool mInNormalTick : 1;
529529

530530
// True if we attempted an extra tick (see CanDoExtraTick) since the last
531531
// vsync and thus shouldn't allow another.
532-
bool mAttemptedExtraTickSinceLastVsync : 1 = false;
532+
bool mAttemptedExtraTickSinceLastVsync : 1;
533533

534-
bool mHasExceededAfterLoadTickPeriod : 1 = false;
534+
bool mHasExceededAfterLoadTickPeriod : 1;
535535

536-
bool mHasImageAnimations : 1 = false;
536+
bool mHasImageAnimations : 1;
537537

538-
bool mHasStartedTimerAtLeastOnce : 1 = false;
538+
bool mHasStartedTimerAtLeastOnce : 1;
539539

540540
mozilla::TimeStamp mMostRecentRefresh;
541541
mozilla::TimeStamp mTickStart;

‎layout/generic/nsFirstLetterFrame.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class nsFirstLetterFrame : public nsContainerFrame {
8484
bool UseTightBounds() const;
8585

8686
protected:
87-
nscoord mBaseline = 0;
87+
nscoord mBaseline;
8888

8989
void DrainOverflowFrames(nsPresContext* aPresContext);
9090
};

‎layout/generic/nsFrameSetFrame.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ class nsHTMLFramesetFrame final : public nsContainerFrame {
187187
bool mNeedFirstReflowWork = false;
188188
nscolor mParentBorderColor;
189189
int32_t mParentBorderWidth;
190-
int32_t mPrevNeighborOrigSize = 0; // used during resize
191-
int32_t mNextNeighborOrigSize = 0;
190+
int32_t mPrevNeighborOrigSize; // used during resize
191+
int32_t mNextNeighborOrigSize;
192192
int32_t mMinDrag;
193193
int32_t mChildCount;
194194
};

‎layout/generic/nsRubyBaseContainerFrame.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class nsRubyBaseContainerFrame final : public nsContainerFrame {
8787
void PullOneColumn(nsLineLayout* aLineLayout, PullFrameState& aPullFrameState,
8888
mozilla::RubyColumn& aColumn, bool& aIsComplete);
8989

90-
nscoord mBaseline = 0;
90+
nscoord mBaseline;
9191

9292
// Leading produced by descendant ruby annotations.
9393
mozilla::RubyBlockLeadings mDescendantLeadings;

‎layout/ipc/RemoteLayerTreeOwner.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class RemoteLayerTreeOwner final {
5959
private:
6060
// The process id of the remote frame. This is used by the compositor to
6161
// do security checks on incoming layer transactions.
62-
base::ProcessId mTabProcessId = 0;
62+
base::ProcessId mTabProcessId;
6363
// The layers id of the remote frame.
6464
LayersId mLayersId;
6565
// The compositor options for this layers id. This is only meaningful if

‎layout/mathml/nsMathMLContainerFrame.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1197,7 +1197,7 @@ class nsMathMLContainerFrame::RowChildFrameIterator {
11971197
bool mAddOperatorSpacing;
11981198
nsMargin mMargin;
11991199

1200-
nscoord mItalicCorrection = 0;
1200+
nscoord mItalicCorrection;
12011201
MathMLFrameType mChildFrameType;
12021202
int32_t mCarrySpace;
12031203
MathMLFrameType mFromFrameType;

‎layout/painting/nsDisplayList.cpp‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3742,10 +3742,7 @@ bool nsDisplayTableBackgroundImage::IsInvalid(nsRect& aRect) const {
37423742
nsDisplayThemedBackground::nsDisplayThemedBackground(
37433743
nsDisplayListBuilder* aBuilder, nsIFrame* aFrame,
37443744
const nsRect& aBackgroundRect)
3745-
: nsPaintedDisplayItem(aBuilder, aFrame),
3746-
mBackgroundRect(aBackgroundRect),
3747-
mThemeTransparency(nsITheme::eUnknownTransparency),
3748-
mAppearance(StyleAppearance::None) {
3745+
: nsPaintedDisplayItem(aBuilder, aFrame), mBackgroundRect(aBackgroundRect) {
37493746
MOZ_COUNT_CTOR(nsDisplayThemedBackground);
37503747
}
37513748

‎layout/painting/nsDisplayListInvalidation.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ class nsDisplaySVGEffectGeometry : public nsDisplayItemGeometry {
172172
gfxRect mBBox;
173173
gfxPoint mUserSpaceOffset;
174174
nsPoint mFrameOffsetToReferenceFrame;
175-
bool mHandleOpacity = false;
175+
bool mHandleOpacity;
176176
};
177177

178178
class nsDisplayMasksAndClipPathsGeometry : public nsDisplaySVGEffectGeometry {

‎layout/svg/SVGFilterInstance.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ class SVGFilterInstance {
245245
/**
246246
* The 'primitiveUnits' attribute value (objectBoundingBox or userSpaceOnUse).
247247
*/
248-
uint16_t mPrimitiveUnits = SVG_UNIT_TYPE_USERSPACEONUSE;
248+
uint16_t mPrimitiveUnits;
249249

250250
/**
251251
* The index of the FilterPrimitiveDescription that this SVG filter should use

0 commit comments

Comments
 (0)