Skip to content

warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 #633

Description

@cpeterso

clang version 11.0.0 warning:

media/libcubeb/src/cubeb_mixer.cpp:336:14 [-Wimplicit-const-int-float-conversion] implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648

maxval = INT_MAX;

Activity

  1. ChunMinChang commented on Dec 21, 2020

    @ChunMinChang
    Member

    I guess this can be fixed easily in cubeb_mixer.cpp. However, it seems a good opportunity to replace the old mixer code by the new audio-mixer in Windows and Linux backends. We've run it in macOS (Rust) backend for a long time and the C API is ready.

  2. cpeterso commented on Dec 21, 2020

    @cpeterso
    ContributorAuthor

    it seems a good opportunity to replace the old mixer code by the new audio-mixer in Windows and Linux backends. We've run it in macOS (Rust) backend for a long time and the C API is ready.

    I forgot to mention that I'm building Firefox on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions