Repository navigation
XFA: measure.pushFont is not a function — rich text containing <b> or <i> breaks layout #22023
Description
Activity
Thanks for identifying the missing call. I reproduced the failure in 6.3.289 with a synthetic two-page XFA form containing nested
<b>/<i>tags.One alternative to adding
TextMeasure.pushFontis to prepend the semantic styles in theBandIconstructors and remove their$pushGlyphsoverrides, letting the existingXhtmlObjectpath handle measurement:// B constructor, after super: this.style = `font-weight:bold;${this.style}`; // I constructor, after super: this.style = `font-style:italic;${this.style}`;
Prepending keeps explicit document styles such as
font-weight:normaleffective. It also gives the rendered elements inline styles; restoring only the missing method left the text visually normal under the standard viewer CSS in my check.I put the source patch, minimal PDFs and runnable comparison here. The same 11 checks pass with the repair in Chrome and the legacy distribution in Node.js; the original passes only the plain-text and disabled-XFA controls. The checks cover both nesting orders, size/spacing/wrapping, explicit normal overrides, and editing/saving/reopening twice while preserving both pages and a non-interactive field.
These results use synthetic files, not your original document, and do not represent the full upstream test suite. I hope the small repro and patch are useful for investigating this.
src/core/xfa/xhtml.jscallsmeasure.pushFont(...)in two places:TextMeasureinsrc/core/xfa/text.jsdefinespushData,popFont,addPara,addStringandcompute. There is nopushFonton it, nor onFontSelector.So any XFA document whose rich text contains
<b>or<i>throwsTypeError: measure.pushFont is not a functionduring layout.Why it is hard to recognise
XFAFactory._createPagescatches the error and only warns, so no pages are built andgetDocumentrejects with:which names neither bold text nor the missing method. A document differing from a working one by a single
<b>fails with a message that points nowhere near the cause.Reproduction
Load any dynamic XFA document (
enableXfa: true) whose rich text contains a<b>or<i>element, for example anexDataofcontentType="text/html"holding:Confirmed on
mastertoday; originally found on 4.6.82.Suggested fix
Add to
TextMeasure:The margin has to be an object of
NaNs rather thannull, becauseFontSelector.pushDatatestsisNaN(margin[side]). That is exactly whatXhtmlObject[$pushGlyphs]already passes on the path that works.