Attach (recommended) or Link to PDF file
Not applicable, this is about the contents of the pdfjs-dist package.
Web browser and its version
Not applicable
Operating system and its version
Not applicable
PDF.js version
6.4.299 (pdfjs-dist on npm)
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem
npm pack pdfjs-dist@6.4.299 && tar -tzf pdfjs-dist-6.4.299.tgz | grep -i -e license -e quickjs
What is the expected behavior?
Like the other bundled third-party code in wasm/ (LICENSE_JBIG2, LICENSE_OPENJPEG, LICENSE_QCMS and their LICENSE_PDFJS_* counterparts) and in standard_fonts/ (LICENSE_FOXIT, LICENSE_LIBERATION), the QuickJS sandbox files come with their license text, so that applications that serve these files (the sandbox has to be served for form scripts) can meet the MIT notice requirement by copying the folder.
What went wrong?
wasm/quickjs-eval.js and wasm/quickjs-eval.wasm are shipped without a license file. external/quickjs/README.md states that QuickJS and pdf.js.quickjs are MIT licensed, but the gulp task that copies the files ("external/quickjs/quickjs-eval.js", "external/quickjs/quickjs-eval.wasm", base external/quickjs) doesn't include a LICENSE_* file, unlike the openjpeg, qcms, jbig2 and standard font tasks next to it.
A LICENSE_QUICKJS (QuickJS, Fabrice Bellard and Charlie Gordon) plus a LICENSE_PDFJS_QUICKJS (pdf.js.quickjs) in external/quickjs/, copied by the same task, would match the existing pattern.
Attach (recommended) or Link to PDF file
Not applicable, this is about the contents of the
pdfjs-distpackage.Web browser and its version
Not applicable
Operating system and its version
Not applicable
PDF.js version
6.4.299 (
pdfjs-diston npm)Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem
What is the expected behavior?
Like the other bundled third-party code in
wasm/(LICENSE_JBIG2,LICENSE_OPENJPEG,LICENSE_QCMSand theirLICENSE_PDFJS_*counterparts) and instandard_fonts/(LICENSE_FOXIT,LICENSE_LIBERATION), the QuickJS sandbox files come with their license text, so that applications that serve these files (the sandbox has to be served for form scripts) can meet the MIT notice requirement by copying the folder.What went wrong?
wasm/quickjs-eval.jsandwasm/quickjs-eval.wasmare shipped without a license file.external/quickjs/README.mdstates that QuickJS and pdf.js.quickjs are MIT licensed, but the gulp task that copies the files ("external/quickjs/quickjs-eval.js","external/quickjs/quickjs-eval.wasm", baseexternal/quickjs) doesn't include aLICENSE_*file, unlike the openjpeg, qcms, jbig2 and standard font tasks next to it.A
LICENSE_QUICKJS(QuickJS, Fabrice Bellard and Charlie Gordon) plus aLICENSE_PDFJS_QUICKJS(pdf.js.quickjs) inexternal/quickjs/, copied by the same task, would match the existing pattern.