Support @ for matrix multiplication #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems fine. I have nothing against removing Python 2 support at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meaning of
*is ambiguous: Some libraries such as NumPy use it for elementwise multiplication, others for matrix multiplication. Since Python3 and PEP465, there is a new operator@for matrix multiplication.This pull request adds
@as an alias for*and includes some workarounds so that the tests using@can be skipped underPython 2Python <= 3.4, where it is a syntax error. (Not sure how long you plan to support Python 2, which has reached its end-of-life, see https://python3statement.org/ ).