log compute - taylor series #956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
May 13, 2025
Collaborator
skirpichev
left a comment
There was a problem hiding this comment.
Don't forgot to add tests, probably to test_log().
mpmath/ctx_mp.py
Outdated
|
|
||
| def _nthroot(ctx, x, n): | ||
| if hasattr(x, '_mpf_'): | ||
| if ctx._is_float_type(x): |
Collaborator
There was a problem hiding this comment.
I suggest put such refactoring changes separately.
mpmath/libmp/libelefun.py
Outdated
Comment on lines
704
to
708
| s = log_taylor(to_fixed(x, wp), wp) # returns fixed-point s | ||
| sb = s.bit_length() # bit count of fixed point | ||
| rman = s << (sb) # divide by 2^(-(bits)) | ||
| rexp = -(sb+wp) # to get exponent, get negative of (bits + wp) | ||
| return from_man_exp(rman, rexp, prec, rnd) # input mantissa, exponent |
Collaborator
There was a problem hiding this comment.
I think you won't comment obvious steps. While stuff from the TODO could be rather helpful to describe what's going on in this block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.