Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: n8n-io/n8n
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: n8n@1.22.1
Choose a base ref
...
head repository: n8n-io/n8n
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: n8n@1.22.2
Choose a head ref
  • 7 commits
  • 23 files changed
  • 7 contributors

Commits on Dec 27, 2023

  1. fix(Redis Trigger Node): Activating a workflow with a Redis trigger f… 

    …ails (#8129)

## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.

We were awaiting for the promise to resolve before returning. Because
the trigger method does not return until the first message is received
or the connection errors, the requests that actives the workflows did
not respond making the activation button irresponsive.

Without the change:

https://www.loom.com/share/769b26d5d4ee407e999344fab3905eae

With the change:

https://www.loom.com/share/d1691ee1941248bc97f2ed97b0c129a3

## Related tickets and issues

https://linear.app/n8n/issue/ADO-895/activating-a-workflow-with-a-redis-trigger-fails


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
    @RicardoE105 @ivov
    RicardoE105 authored and ivov committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    babca25 View commit details
    Browse the repository at this point in the history

  2. fix(Asana Node): Omit body from GET, HEAD, and DELETE requests (#8057) 

    Avoid unnecessarily including a request body with GET and HEAD requests.
Per RFC 7230 clients should not include a body for these requests, and
we (Asana) are rolling out an infrastructure change that will cause
these requests to fail.
    @ivov
    Aaron Gutierrez authored and ivov committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    094c9d7 View commit details
    Browse the repository at this point in the history

  3. fix(editor): Fix operation change failing in certain conditions (#8114) 

    ## Summary
This PR handles the case when there are multiple parameters with the
same name but different `options` and `displayOptions`. In this case, if
one of such fields is set, changing the dependent parameter value so the
other should be shown causes an error in case their options are not
compatible (this
[check](https://github.com/n8n-io/n8n/blob/7806a65229878a473f5526bad0b94614e8bfa8aa/packages/workflow/src/NodeHelpers.ts#L786)).

#### Example:
LDAP node has two `options` properties with the same name:
1. `attributes` with predefined options (`add`, `replace`, `delete`).
Shown when **Update** operation is selected
2. `attributes` with a collection of `attribute` objects. Shows for the
**Create** operation

Setting one of these parameter values and switching operation so the
other is shown breaks the app.
This PR checks if there is a value saved for such parameter and removes
it before calling `getNodeParameters` in `valueChanged` handler.

## Related tickets and issues
Fixes ADO-1589

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
    @MiloradFilipovic @ivov
    MiloradFilipovic authored and ivov committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    aaca64a View commit details
    Browse the repository at this point in the history

  4. fix(editor): Prevent canvas undo/redo when NDV is open (#8118) 

    ## Summary
Preventing canvas undo/redo while NDV or any modal is open. We already
had a NDV open check in place but looks like it was broken by unreactive
ref inside `useHistoryHelper` composable.
This PR fixes this by using store getter directly inside the helper
method and adds modal open check.

## Related tickets and issues
Fixes ADO-657

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
    @MiloradFilipovic @ivov
    MiloradFilipovic authored and ivov committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    43eca24 View commit details
    Browse the repository at this point in the history

  5. fix(editor): Prevent browser zoom when scrolling inside sticky edit m… 

    …ode (#8116)

## Summary
Fixes a bug where zooming inside a sticky edit mode would trigger
browser zoom. Instead, triggers regular canvas zoom.


## Related tickets and issues
Fixes ADO-1581


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
    @MiloradFilipovic @ivov
    MiloradFilipovic authored and ivov committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    e5135b1 View commit details
    Browse the repository at this point in the history

  6. fix(core): Fix issue that pinnedData is not used with Test-Webhooks (#… 

    …8123)

## Summary
When a workflow gets started via a Test-Webhook the pinned data does get
ignored and the nodes executed anyway.



## Related tickets and issues
> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
reviewers.



## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [X] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
    @janober @mutdmour @ivov
    2 people authored and ivov committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    9c99075 View commit details
    Browse the repository at this point in the history

  7. 🚀 Release 1.22.2 (#8162) 

    ##
[1.22.2](https://github.com/n8n-io/n8n/compare/n8n@1.22.1...n8n@1.22.2)
(2023-12-27)


### Bug Fixes

* **Asana Node:** Omit body from GET, HEAD, and DELETE requests
([#8057](#8057))
([094c9d7](094c9d7))
* **core:** Fix issue that pinnedData is not used with Test-Webhooks
([#8123](#8123))
([9c99075](9c99075))
* **editor:** Fix operation change failing in certain conditions
([#8114](#8114))
([aaca64a](aaca64a)),
closes
[/github.com/n8n-io/n8n/blob/7806a65229878a473f5526bad0b94614e8bfa8aa/packages/workflow/src/NodeHelpers.ts#L786](https://github.com//github.com/n8n-io/n8n/blob/7806a65229878a473f5526bad0b94614e8bfa8aa/packages/workflow/src/NodeHelpers.ts/issues/L786)
* **editor:** Prevent browser zoom when scrolling inside sticky edit
mode ([#8116](#8116))
([e5135b1](e5135b1))
* **editor:** Prevent canvas undo/redo when NDV is open
([#8118](#8118))
([43eca24](43eca24))
* **Redis Trigger Node:** Activating a workflow with a Redis trigger
fails ([#8129](#8129))
([babca25](babca25))

Co-authored-by: ivov <ivov@users.noreply.github.com>
    @github-actions @ivov
    github-actions[bot] and ivov authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    cab78a5 View commit details
    Browse the repository at this point in the history
Loading