Skip to content

Conversation

@netroy
Copy link
Contributor

@netroy netroy commented Feb 20, 2023

No description provided.

@netroy netroy changed the title fix(core): Do now bypass auth on urls containing .svg fix(core): Do not explicitly bypass auth on urls containing .svg Feb 20, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 20, 2023
@netroy netroy marked this pull request as draft February 20, 2023 19:37
@netroy netroy force-pushed the fix-svg-auth-bypass branch from 0787c3d to 2bd2f64 Compare February 20, 2023 20:05
All valid exclusions are already in the `isAuthExcluded` function.
The removed lines aren't used anymore, and are safe to delete.
@netroy netroy force-pushed the fix-svg-auth-bypass branch from 2bd2f64 to 450bc32 Compare February 21, 2023 09:01
@netroy netroy marked this pull request as ready for review February 21, 2023 09:01
@netroy netroy merged commit f58573d into n8n-io:master Feb 21, 2023
@netroy netroy deleted the fix-svg-auth-bypass branch February 21, 2023 10:52
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 21, 2023
janober added a commit that referenced this pull request Feb 21, 2023
* 🚀 Release 0.216.1

* fix(core): Do not allow arbitrary path traversal in the credential-translation endpoint (#5522)

* fix(core): Do not allow arbitrary path traversal in BinaryDataManager (#5523)

* fix(core): User update endpoint should only allow updating email, firstName, and lastName (#5526)

* fix(core): Do not explicitly bypass auth on urls containing `.svg` (#5525)

* 📚 Update CHANGELOG.md

---------

Co-authored-by: janober <janober@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
@janober
Copy link
Member

janober commented Feb 21, 2023

Got released with n8n@0.216.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team skip-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants