Skip to content

fix(core): Update pruning related config defaults for v1 #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2023
Merged

fix(core): Update pruning related config defaults for v1 #6577

merged 3 commits into from
Jul 4, 2023

Conversation

@netroy
Copy link
Contributor

@netroy netroy commented Jun 30, 2023 •
edited
Loading

  • Save manual executions by default
  • Enable executions data pruning by default
  • Keep a maximum of 1000 executions by default

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy netroy changed the title fix(core): Update pruning related config defaults for v1 fix(core): Update pruning related config defaults for v1 N8N-6598 Jun 30, 2023
@netroy netroy changed the title fix(core): Update pruning related config defaults for v1 N8N-6598 fix(core): Update pruning related config defaults for v1 Jun 30, 2023
@netroy
fix(core): Update pruning related config defaults for v1
a93fa60 
* Do not save successful executions by default
* Save manual executions by default
* Enable executions data pruning by default
* Keep a maximum of 1000 executions by default
@netroy netroy force-pushed the v1-pruning-defaults branch from 445a6d7 to a93fa60 Compare June 30, 2023 10:08
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/1.0.0@d0eb5d4). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 9719e82 differs from pull request most recent head 937d036. Consider uploading reports for the commit 937d036 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##             release/1.0.0    #6577   +/-   ##
================================================
  Coverage                 ?   28.66%           
================================================
  Files                    ?     2998           
  Lines                    ?   186246           
  Branches                 ?    20600           
================================================
  Hits                     ?    53381           
  Misses                   ?   132056           
  Partials                 ?      809

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 30, 2023
@ivov ivov added the v1 Issues related to the release of n8n version 1.x.x label Jun 30, 2023
csuermann
csuermann reviewed Jun 30, 2023
View reviewed changes
@netroy @csuermann
Update packages/cli/src/config/schema.ts
9719e82 
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
@netroy netroy requested a review from csuermann June 30, 2023 13:12
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 30, 2023 •
edited
Loading

1 failed and 2 flaky tests on run #1364 ↗︎

1 117 0 0 Flakiness 2

Details:

🌳 v1-pruning-defaults 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 9719e8211e
Status: Failed Duration: 05:42 💡
Started: Jun 30, 2023 2:02 PM Ended: Jun 30, 2023 2:07 PM
Failed  2-credentials.cy.ts • 1 failed test

View Output Video

Test Artifacts
Credentials > should sort credentials Output Screenshots Video
Failed  14-data-transformation-expressions.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  17-sharing.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  24-ndv-paired-item.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output Video

Test Artifacts

The first 5 failed specs are shown, see all 21 specs in Cypress Cloud.

Flakiness  16-webhook-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Webhook Trigger node > should listen for a GET request Output Screenshots Video
Flakiness  4-node-creator.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Node Creator > should correctly append manual trigger for regular actions > should not append manual trigger when source is canvas related Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

csuermann
csuermann reviewed Jul 3, 2023
View reviewed changes
@netroy @csuermann
Apply suggestions from code review
937d036 
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
@netroy netroy merged commit ffb4e47 into release/1.0.0 Jul 4, 2023
@netroy netroy deleted the v1-pruning-defaults branch July 4, 2023 08:49
This was referenced Jul 5, 2023
Closed
Merged
@janober
Copy link
Member

janober commented Jul 13, 2023

Got released with n8n@1.0.2

Lucaber added a commit to Lucaber/n8n-docs that referenced this pull request Oct 17, 2023
@Lucaber
Update defaults of prune environment variables
bf97e9f 
PR n8n-io/n8n#6577
@Lucaber Lucaber mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csuermann csuermann csuermann approved these changes

Assignees

No one assigned

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released v1 Issues related to the release of n8n version 1.x.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@netroy @janober @csuermann @ivov