Skip to content

Conversation

@michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/possible-airtable-bug-when-creating-attachment-record/29288

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Sep 21, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (303bc8e) 32.81% compared to head (aaa8a55) 32.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7227      +/-   ##
==========================================
- Coverage   32.81%   32.81%   -0.01%     
==========================================
  Files        3348     3348              
  Lines      199868   199868              
  Branches    21908    21908              
==========================================
- Hits        65582    65580       -2     
- Misses     133181   133183       +2     
  Partials     1105     1105              
Files Changed Coverage Δ
...-base/nodes/Airtable/v2/methods/resourceMapping.ts 17.64% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 21, 2023

Passing run #2233 ↗︎

0 235 3 0 Flakiness 0

Details:

🌳 node-717-cant-upload-attachments-after-airtable-node-update 🖥️ browsers:node...
Project: n8n Commit: aaa8a554d8
Status: Passed Duration: 07:41 💡
Started: Sep 21, 2023 11:38 AM Ended: Sep 21, 2023 11:45 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 2af967c into master Sep 21, 2023
@michael-radency michael-radency deleted the node-717-cant-upload-attachments-after-airtable-node-update branch September 21, 2023 12:00
netroy pushed a commit that referenced this pull request Sep 21, 2023
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
netroy added a commit that referenced this pull request Sep 21, 2023
## [1.8.1](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.8.1)
(2023-09-21)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](#7227))
([ebfcc87](ebfcc87))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](#7229))
([fb36b0a](fb36b0a))
* Ensure new Set node is on top of search list
([#7215](#7215))
([c8fb06f](c8fb06f))
* Issue enforcing user limits on start plan
([#7188](#7188))
([50a4c5e](50a4c5e))


### Reverts

* **core:** Add command to trigger license refresh on workers
([#7184](#7184))
([6ac19a5](6ac19a5))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

This was referenced Sep 27, 2023
netroy added a commit that referenced this pull request Sep 28, 2023
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0)
(2023-09-28)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](#7227))
([2af967c](2af967c))
* **core:** Change WorkflowHistory nodes/connections columns to be json
([#7282](#7282))
([a80abad](a80abad))
* **core:** Fix binary data manager check on pruning
([#7251](#7251))
([484035e](484035e))
* **core:** Fix missing execution ID in webhook-based workflow producing
binary data ([#7244](#7244))
([33991e9](33991e9))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](#7229))
([67b985f](67b985f))
* **core:** Make DNS resolution order configurable
([#7272](#7272))
([5b3121c](5b3121c))
* **core:** Make senderId required for all command messages
([#7252](#7252))
([4b01428](4b01428))
* **core:** Prevent executions from displaying Running status
incorrectly ([#7261](#7261))
([861cac5](861cac5))
* **core:** Use consistent timezone-aware timestamps in postgres
([#6948](#6948))
([0132514](0132514)),
closes [#2178](#2178)
[#2810](#2810)
[#3855](#3855)
[#2813](#2813)
* **editor:** Add debug feature docs link
([#7240](#7240))
([4614e1e](4614e1e))
* **editor:** Fix SQL editor issue
([#7236](#7236))
([647fc6c](647fc6c))
* **editor:** Ensure new Set node is on top of search list
([#7215](#7215))
([2491ccf](2491ccf))
* **editor:** Forbid password reset when cloud account is limited in the
number of users [7188](#7188)
([303bc8e](303bc8e))
* **HTTP Request Node:** Add suggestion how to fix '429 - too many
requests' errors ([#7293](#7293))
([0bc33b1](0bc33b1))
* **Item Lists Node:** Concatenate operation pairedItems fix
([#7286](#7286))
([cde23a1](cde23a1))
* **Respond to Webhook Node:** JSON output from expression fix
([#7294](#7294))
([8bc369d](8bc369d))


### Features

* Add onboarding flow
([#7212](#7212))
([01e9340](01e9340))
* **core:** Add secrets provider reload and refactor
([#7277](#7277))
([53a7502](53a7502))
* **core:** Add Tournament as the new default expression evaluator
([#6964](#6964))
([bf74f09](bf74f09))
* **core:** Initial workflow history API
([#7234](#7234))
([0083a9e](0083a9e))
* **core:** Introduce object store service
([#7225](#7225))
([fa84545](fa84545))
* **editor:** Add user cloud ID to telemetry
[#7232](#7232)
([60c152d](60c152d))
* **editor:** Rework banners framework and add email confirmation banner
([#7205](#7205))
([b0e98b5](b0e98b5))
* **MISP Node:** Update credential to support HTTP Request node
([#7268](#7268))
([e4c302c](e4c302c))


### Performance Improvements

* **core:** Skip unneeded calls on every pruning cycle
([#7260](#7260))
([db01164](db01164))

Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team node/issue Issue with a node Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants