Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

[Select] Meaningless && chaining of checkHtml5Validity after $emit #271

Closed
Closed
[Select] Meaningless && chaining of checkHtml5Validity after $emit#271

Description

@kikuomax
kikuomax
opened on Aug 12, 2024

Since $emit is supposed to return nothing (void or undefined), checkHtml5Validity chained with && won't be called.

buefy-next/packages/buefy-next/src/components/select/Select.vue

Line 15 in 185589f

@blur="$emit('blur', $event) && checkHtml5Validity()"

Activity

  1. kikuomax commented on Aug 12, 2024

    @kikuomax
    kikuomax
    on Aug 12, 2024
    CollaboratorAuthor

    Due to this commit, Datepicker and Input had the same issue but they were fixed afterward by replacing the event handler with onBlur provided by the FormElementMixin. Do the same for Select.

  2. kikuomax commented on Aug 12, 2024

    @kikuomax
    kikuomax
    on Aug 12, 2024
    CollaboratorAuthor

    Btw, TypeScript won't tolerate this issue.

  3. kikuomax
    added a commit that references this issue on Aug 14, 2024

    feat(lib): rewrite Select in TS

    6eda254
  4. kikuomax
    added a commit that references this issue on Jan 11, 2025

    TypeScript Rollout Tier 8 - Select (#368)

    6e553fe

  5. kikuomax commented on Jan 18, 2025

    @kikuomax
    kikuomax
    on Jan 18, 2025
    CollaboratorAuthor

    This was fixed by #368.

  6. kikuomax
    closed this as completedon Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions