-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added 0.60.0 release notes #9558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some markup and spelling nitpicks.
But importantly, the PR is missing the list of PRs and Authors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fixup the date too.
You'll need the script at: https://github.com/numba/numba/blob/main/maint/gitlog2changelog.py |
Co-authored-by: Emergency Self-Construct <esc@users.noreply.github.com>
|
I used the command to generate the following list: But had to prune the list since some of the PRs listed were also included in the |
This is to be expected. The script works by looking at given merge commits and using a regular expression on the commit message to work out which PR it was. The |
Using the tag for the patch release is probably not the best idea here, since that is usually made on a release branch. Using the |
|
Putting in the dev tag Am pruning it now. |
|
I just tried with the
|
I think that will give you all commits from the 0.59 AND 0.60 release. I think you will need the |
|
Okay so the pruned PR list and the list in this PR is almost the same. As you pointed out #9367 wasn't in the pruned PR list not sure why, but it is already within this list. I'll add #9559 within this list shortly, the only other PR that were in the pruned list (and not a part of this list) was #9368 which I'm not sure should be a part of this changelog? Edit: Also added #9368 in the list since it seems that the PR for the previous version release notes is present in the |
|
The problem with the release notes PR #9368 is that this is the PR that creates the release notes, so it can not include itself. While the changes that this PR introduced are inlcuded in the release (0.59.0), the PR itself doesn't show up in the release notes. It's a classic chicken and egg issues. The best course of action, IMHO, is to manually add the PR during review. That is to say: a) create the list of PRs and authors |
Do we want to add #9558 to the list of PRs for 0.60 then? Such that we won't have this issue for 0.61 -- also probably the release notes checklist or instructions for generating the release notes need an update. |
|
@kc611 looks good thank you, just waiting on CI now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
As titled, this PR adds changelog for
0.60.0release.