Skip to content

Create NuGet source packages, snupkg #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rprouse merged 6 commits into from
Jan 31, 2021
Merged

Create NuGet source packages, snupkg #3748

rprouse merged 6 commits into from
Jan 31, 2021

Conversation

@rprouse
Copy link
Member

@rprouse rprouse commented Jan 30, 2021 •
edited
Loading

Fixes #3745

@rprouse
- Partially reverts #3464
35aefae 
- Build portable PDBs
- Create snupkg files for uploading symbols
- Reinstate gitlink
@rprouse
Upload snupkg to AppVeyor
009c228
@rprouse rprouse self-assigned this Jan 30, 2021
@rprouse rprouse requested review from jnm2 and mikkelbu January 30, 2021 19:06
mikkelbu
mikkelbu previously approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know that much about this area, but I compare the files with the exising nuspec files and with the change in #3464

@mikkelbu
Copy link
Member

mikkelbu commented Jan 30, 2021 •
edited
Loading

I looked at the build log and remembered that Claire had a comment #3464 (comment) . This could indicate that this is not working correctly.

Also the log states

Portable PDB format is not compatible with GitLink. Please use SourceLink (https://github.com/ctaggart/SourceLink).

@rprouse
Copy link
Member Author

rprouse commented Jan 30, 2021

Thanks for the info @mikkelbu. I've updated to use sourcelink, but I am running into problems. If I build using Visual Studio, the PDBs are properly sourcelinked, but if I build using Cake, they are not. I'll probably need to continue this tomorrow.

jnm2
jnm2 previously approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reinstate gitlink

GitLink is a different, obsolete technology. This PR is introducing the use of Source Link for the first time. 👍

If it was me, I'd use <EmbedAllSources>true</EmbedAllSources> rather than Source Link especially now that the PDBs are only downloaded when requested, but Source Link is the official recommendation usually.

If you do use Source Link, I would recommend adding <EmbedUntrackedSources>true</EmbedUntrackedSources>. (https://github.com/dotnet/sourcelink/blob/master/README.md#using-source-link-in-net-projects)

@rprouse rprouse merged commit 248dae7 into master Jan 31, 2021
@rprouse rprouse deleted the issue/3745 branch January 31, 2021 23:01
This was referenced Mar 6, 2021
Merged
Merged
Merged
This was referenced Mar 14, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikkelbu mikkelbu mikkelbu left review comments

@jnm2 jnm2 jnm2 left review comments

Assignees

@rprouse rprouse

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

After upgrading to NUnit 3.13.0 the debugger enters NUnit code despite having checked "Enable Just My Code"

4 participants

@rprouse @mikkelbu @jnm2