Skip to content

docs(tabs): improve model value examples #5722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kleenkanteen wants to merge 8 commits into
base: v4
Choose a base branch
from
Open

docs(tabs): improve model value examples #5722

kleenkanteen wants to merge 8 commits into from
+58 −18

Conversation

@kleenkanteen
Copy link

@kleenkanteen kleenkanteen commented Dec 20, 2025

I lost 2h because the docs were incorrect. It also caused incorrect AI explanation across multiple LLMs.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  1. The previous explanation incorrectly wrote that the index of the tab matters, when that isn't the case.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Dec 20, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 20, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@5722

commit: 8a65609

benjamincanac
benjamincanac reviewed Dec 20, 2025
View reviewed changes
@benjamincanac benjamincanac changed the title docs(tabs): fix explanation for setting active tab docs(tabs): improve model value examples Dec 21, 2025
benjamincanac
benjamincanac approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the docs to split into two sections, let me know what you think!

@kleenkanteen
Copy link
Author

kleenkanteen commented Dec 21, 2025 •
edited
Loading

looks good.

I was hoping to add a simple example of how setting the default item works, but I guess it's not necesary since the part about the value property controlling it was fixed and added since the last time I looked at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v4 #4488

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kleenkanteen @benjamincanac