[actions] Add release test workflow #2355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 20, 2020
Comment on lines
+10
to
+13
| - uses: actions/setup-node@v2-beta | ||
| with: | ||
| node-version: "14" | ||
| - run: npm install |
Member
There was a problem hiding this comment.
i'd prefer to use my personal action for this instead: https://github.com/es-shims/Array.prototype.entries/blob/11dd526c66c943cc91b8335e2cd028d9cbe67766/.github/workflows/node-4%2B.yml#L44-L47
Member
There was a problem hiding this comment.
k, i tried it out, and since it doesn't support env yet, let's land this as-is for now and i'll iterate on it later :-)
f6dbd92 to
368c663
Compare
52b06f0 to
22902f0
Compare
ljharb
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workflow that tests the
make release ...process by running it with a placeholder version (99.99.99) and ensuring that a new tag is created.This replaces the previous travis process and adds the tag check as a bonus.