[Issue] Adding nvm_grep in install.sh makes CI to fail #2403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jan 12, 2021
Member
ljharb
left a comment
There was a problem hiding this comment.
It's because nvm_reset unsets nvm_grep, which nvm itself needs to function, but in this case, the failing test is failing to source nvm.sh after running the install script, which is a bug in the test. I'll fix and land once tests pass.
cede59f to
9f3397a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply copy/pasting nvm_grep function from nvm.sh to install.sh makes the test
nvm_install_with_node_versionto fail.