Fix potential unbound var error on nvm install #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nvm-sh#2420. When using `nvm install` with an already installed version, Bash (and potentially other shells) may emit an unbound variable error when `set -u` is set. The presence of the error depends on specific shell versions, but appears to happen in MacOS 11.1 (Big Sur) using a recent Bash version installed via Homebrew (as of this writing). The fix accesses `ALIAS` correctly for the case where it is not set by an `alias` option to `nvm install`.
d1b4bad to
3243f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2420, when using
nvm installwith an already installedversion, Bash (and potentially other shells) may emit an unbound
variable error when
set -uis set. The presence of the error dependson specific shell versions, but appears to happen in MacOS 11.1 (Big
Sur) using a recent Bash version installed via Homebrew (as of this
writing).
The fix accesses
ALIAScorrectly for the case where it is not set byan
aliasoption tonvm install.