Skip to content

feat(drafts,messages): Add metadata_pair to both messages and drafts #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AaronDDM merged 3 commits into from
Dec 9, 2025
Merged

feat(drafts,messages): Add metadata_pair to both messages and drafts #430

AaronDDM merged 3 commits into from
Dec 9, 2025

Conversation

@kraju3
Copy link
Contributor

@kraju3 kraju3 commented Jul 18, 2025 •
edited by cursor bot
Loading

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Note

Adds metadata_pair filter to messages and drafts list query params; updates changelog and refines notetaker enum serialization.

  • Models:
    • Messages: Add metadata_pair to ListMessagesQueryParams; document usage in query params docstring.
    • Drafts: Add metadata_pair to ListDraftsQueryParams; document usage in query params docstring.
    • Notetakers: Remove super().__post_init__() and normalize enum fields to string values in ListNotetakerQueryParams.__post_init__.
  • Docs:
    • Update CHANGELOG.md to note support for metadata_pair on messages and drafts list endpoints.

Written by Cursor Bugbot for commit 5a3d97b. This will update automatically on new commits. Configure here.

@kraju3 kraju3 requested a review from AaronDDM July 18, 2025 20:19
@AaronDDM
Copy link
Contributor

AaronDDM commented Jul 18, 2025

Hey can we get a changelog added, and tests if necessary?

Thanks!

@playerzero-ai
Copy link

playerzero-ai bot commented Jul 18, 2025 •
edited
Loading

Pull Request Summary

  • Messages Functionality:

    • Introduced metadata_pair support in ListMessagesQueryParams and FindMessageQueryParams.
    • This enhancement allows users to search and filter messages using metadata key/value pairs.
    • Documentation has been updated to guide developers on utilizing this new feature.

  • Drafts Functionality:

    • Added an optional metadata_pair field to ListDraftsQueryParams.
    • This addition enables filtering of draft messages based on custom metadata, improving search and retrieval capabilities for drafts.

  • Overall Impact:

    • These changes enhance the search and filtering capabilities for both messages and drafts by allowing the use of metadata key/value pairs.
    • Improves developer experience by providing clear documentation on the new functionality.

Functional Tests

  • Verify that drafts can be filtered using the new 'metadata_pair' field and that the correct drafts are returned based on the specified metadata key/value pair.
  • Ensure that messages can be searched and filtered using the 'metadata_pair' query parameter, and validate that the results match the expected metadata key/value criteria.
  • Test the system's behavior when 'metadata_pair' is not provided, ensuring that the default search and retrieval functionality for drafts and messages remains unaffected.
  • Check that the UI correctly reflects the use of 'metadata_pair' in search queries for both drafts and messages, and that it provides appropriate feedback or results to the user.

Files Changed

File Name Summary
nylas/models/messages.py - Added metadata_pair support in ListMessagesQueryParams and FindMessageQueryParams for metadata-based message search.
- Updated docs with metadata_pair usage details.
nylas/models/drafts.py - Added optional metadata_pair field to ListDraftsQueryParams for filtering drafts by metadata key/value.

View more in PlayerZero
updated: Jul 19 @ 12:06 AM UTC

@playerzero-ai
Copy link

playerzero-ai bot commented Sep 26, 2025

nylas + PlayerZero

Simulations

Project Branch Status Updated (UTC)
nylas metadata-query-param -> main Error 0/3 passed Sep 26 @ 06:17 PM UTC

View more in PlayerZero
updated: Sep 26 @ 06:17 PM UTC

Kiran Raju and others added 3 commits December 9, 2025 14:00
@AaronDDM
Add metadata_pair to both messages and drafts
aeb17d8
@AaronDDM
updated changelog
f29a7f6
@AaronDDM
Update .pylintrc to disable 'too-many-positional-arguments' warning; …
5a3d97b 
…format metadata_pair docstring for clarity; remove unnecessary super() call in ListNotetakerQueryParams
@AaronDDM AaronDDM force-pushed the metadata-query-param branch from e0aed33 to 5a3d97b Compare December 9, 2025 19:02
@AaronDDM AaronDDM changed the title Add metadata_pair to both messages and drafts feat(drafts,messages): Add metadata_pair to both messages and drafts Dec 9, 2025
@AaronDDM AaronDDM merged commit e2359da into main Dec 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AaronDDM AaronDDM AaronDDM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kraju3 @AaronDDM