Skip to content

README.md edits#52

Open
lasersPew wants to merge 2 commits into
namanshergill:internalfrom
lasersPew:internal
Open

README.md edits#52
lasersPew wants to merge 2 commits into
namanshergill:internalfrom
lasersPew:internal

Conversation

@lasersPew
Copy link
Copy Markdown

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 12, 2021

CLA assistant check
All committers have signed the CLA.

@namanshergill
Copy link
Copy Markdown
Owner

How come GitHub thinks EVERY file in the project is being changed in this PR🤔

@namanshergill
Copy link
Copy Markdown
Owner

Can you use the cherry pick command to only include the readme changes? I can also manually move them over if you would like, with the changes I mentioned in the comments above, would you prefer that?

@lasersPew
Copy link
Copy Markdown
Author

I just changed the readme. Te things I omitted is included btw in #51

@namanshergill
Copy link
Copy Markdown
Owner

I just changed the readme. Te things I omitted is included btw in #51

Yep I went through it! I mostly mentioned the cherry pick command because GitHub thinks every file is being changed, so you can only cherry pick the Readme, or I can manually move the changes over with my comments I mentioned above if you would prefer that?

@lasersPew
Copy link
Copy Markdown
Author

Well, you can manually move the changes since i couldn't cherrypick the readme.

@namanshergill
Copy link
Copy Markdown
Owner

Oh whoops, this completely slipped my mind, sorry! Gonna work on adding the wiki asap now that I'm able to work on the project again.

@HikaruIchijyo
Copy link
Copy Markdown

Oh whoops, this completely slipped my mind, sorry! Gonna work on adding the wiki asap now that I'm able to work on the project again.

Yay finally

@lasersPew
Copy link
Copy Markdown
Author

Reopened this PR as I added more changes to the README

  • Brought back the features
  • Changed Logo Link
  • Retractable Screenshots
  • Added Buy me a Coffee image

@namanshergill
Copy link
Copy Markdown
Owner

Hey! Thanks for fixing the issue with all files being marked as changed (that would have messed git blame and would have made it hard to track where exactly a specific part of code was changed in the past).

There are a couple of changes I would like to mention (for example, files under assets are compiled with the app, so might need to move the coffee icon), but I’m currently on vacation so will share them in the next weekend.

Thanks for the PR, the repo did need a better organised readme

Added Logo link
Added Buy me a Coffee link
Added link to wiki
Added Retractable Screenshots
@lasersPew
Copy link
Copy Markdown
Author

There are a couple of changes I would like to mention (for example, files under assets are compiled with the app, so might need to move the coffee icon), but I’m currently on vacation so will share them in the next weekend.

Would placing it onto ./repoassets do the trick?

@lasersPew lasersPew changed the title Edited README.md and added som QoL updates to the repository README.md edits Feb 18, 2024
Copy link
Copy Markdown

@RKerkhof123 RKerkhof123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets/bmac.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants