fixed wrong table startY per page due to header columnSpacing and border #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table actually was positioned above where it should, which messes up the page layout. This fixes that. This also fixes a regression with headerHeight: "this.headerHeight" does not work when using multiple tables, or nested tables, with different header heights on the same pdf document, when page breaks occur. After a page break, the last headerHeight was used, no matter which table it belonged to, which breaks everything. So this fixes that regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table actually was positioned above where it should, which messes up the page layout. This fixes that.
This also fixes a regression with headerHeight:
"this.headerHeight" does not work when using multiple tables, or nested tables, with different header heights on the same pdf document, when page breaks occur. After a page break, the last headerHeight was used, no matter which table it belonged to, which breaks everything. So this fixes that regression.