Skip to content

Fixed color of MuiIconButton in gruvboxDark.js #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deluan merged 2 commits into from
Oct 29, 2025
Merged

Fixed color of MuiIconButton in gruvboxDark.js #4585

deluan merged 2 commits into from
Oct 29, 2025

Conversation

@konstantin-morenko
Copy link
Contributor

@konstantin-morenko konstantin-morenko commented Oct 13, 2025 •
edited
Loading

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Other (please describe):

Checklist

Please review and check all that apply:

  • My code follows the project’s coding style
  • I have tested the changes locally
  • I have added or updated documentation as needed
  • I have added tests that prove my fix/feature works (or explain why not)
  • All existing and new tests pass

How to Test

Screenshots / Demos (if applicable)

Additional Notes

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 13, 2025

Summary of Changes

Hello @konstantin-morenko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor visual bug within the gruvboxDark theme by explicitly defining the color for MuiIconButton labels. The change ensures that these interactive elements render with the correct hexadecimal color code, thereby improving the theme's consistency and overall user interface presentation.

Highlights

  • MuiIconButton Styling: Introduced specific styling for MuiIconButton components within the gruvboxDark theme to ensure their labels display with the correct color (#ebdbb2).
  • Theme Consistency: Resolved a visual inconsistency by explicitly setting the color for MuiIconButton labels, aligning them with the intended aesthetic of the gruvboxDark theme.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the color of MuiIconButton for the gruvboxDark theme. The implementation uses the label class key, which is deprecated in Material-UI v4. My feedback suggests using the root class key instead, which is the current best practice and ensures better long-term maintainability.

@konstantin-morenko @gemini-code-assist
Update ui/src/themes/gruvboxDark.js
3145222 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@deluan
Copy link
Member

deluan commented Oct 29, 2025

Thanks!

@deluan deluan merged commit 465846c into navidrome:master Oct 29, 2025
6 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 9, 2025
Merged
Henry147147 pushed a commit to Henry147147/navidrome that referenced this pull request Nov 13, 2025
@konstantin-morenko @gemini-code-assist @henry1477
fix(ui): fix color of MuiIconButton in Gruvbox Dark theme (navidrome#…
dbbb3e5 
…4585)

* Fixed color of MuiIconButton in gruvboxDark.js

* Update ui/src/themes/gruvboxDark.js

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@konstantin-morenko @deluan