Fix library selection state for single-library users #4686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a state synchronization bug where users with a single library or users who lose access to previously selected libraries encounter empty content due to stale selectedLibraries persisting in localStorage/Redux state.
Key Changes:
- Added validation logic in
libraryReducer.jsto filter out invalid library IDs from selections and automatically reset selection for single-library users - Added defensive validation in
wrapperDataProvider.jsto validate selected libraries against current user libraries before applying filters - Added comprehensive test coverage (10 new tests) covering various state transition scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/src/reducers/libraryReducer.js | Implements core fix by validating selectedLibraries against userLibraries when SET_USER_LIBRARIES is dispatched, filtering invalid IDs and resetting to empty for single-library users |
| ui/src/dataProvider/wrapperDataProvider.js | Adds defensive layer in getSelectedLibraries() to validate selections from localStorage and return empty array for single-library users |
| ui/src/reducers/libraryReducer.test.js | New test file with comprehensive coverage for SET_USER_LIBRARIES, SET_SELECTED_LIBRARIES, and edge cases including stale IDs, single-library transitions, and empty library lists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes issues where users with a single library see no content when selectedLibraries in localStorage contains library IDs they no longer have access to (e.g., after removing libraries or switching accounts). Changes: - libraryReducer: Validate selectedLibraries when SET_USER_LIBRARIES is dispatched, filtering out invalid IDs and resetting to empty for single-library users (empty means 'all accessible libraries') - wrapperDataProvider: Add defensive validation in getSelectedLibraries to check against current user libraries before applying filters - Add comprehensive test coverage for reducer validation logic Fixes #4553, #4508, #4569
c3126f7 to
f17da06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a state synchronization bug where users with a single library or changing library access see no content due to stale
selectedLibrariesin localStorage/Redux state.The issue occurs when:
selectedLibrariescontaining library IDs they no longer have access to (e.g., after removing libraries or switching accounts)LibrarySelectorcomponent doesn't render for single-library users, providing no UI to fix the selectionRelated Issues
Fixes #4553
Fixes #4508
Fixes #4569
Type of Change
Checklist
Please review and check all that apply:
How to Test
Prerequisites:
Test Scenario 1: Single library with stale state
localStorage.setItem('state', JSON.stringify({library: {userLibraries: [{id: 1, name: "Music Library"}], selectedLibraries: [2]}}))Test Scenario 2: Switching from multiple to single library
Test Scenario 3: Account switching
Additional Notes
Implementation:
selectedLibrarieswhenSET_USER_LIBRARIESis dispatched, filtering out invalid IDs and resetting to empty array for single-library usersgetSelectedLibraries()to check against current user libraries before applying filtersImpact: