Skip to content

Fix PWA notification toolbar color #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deluan merged 3 commits into from
May 12, 2021
Merged

Fix PWA notification toolbar color #1083

deluan merged 3 commits into from
May 12, 2021

Conversation

@Dnouv
Copy link
Contributor

@Dnouv Dnouv commented May 3, 2021 •
edited
Loading

As mentioned in issue #1063, in the PWA, the color of the notification bar was not similar to the theme; in this PR, I have tried to fix issue #1063 by setting the toolbar color as the theme's palette light color( if it is defined or else to the main color of the palette). Please find the screenshots of the app after changes, (Fixes #1063 )

In Spotify-ish theme:
br_509

In Extra-Dark theme:
br_509

In Ligera theme:
br_509

Feedbacks are most welcomed. Thank you!

deluan
deluan requested changes May 7, 2021
View reviewed changes
Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this, and for testing with multiple themes. Take a look at the comments below

@deluan
Copy link
Member

deluan commented May 12, 2021

Hey @Dnouv I converted the component into a hook, as it was really not a component and not rendering anything. Thanks for the PR!

@deluan deluan merged commit 0c93db8 into navidrome:master May 12, 2021
@deluan
Copy link
Member

deluan commented May 12, 2021

By the way, I'm seeing this error below in the console referring the Ligera theme. Doesn't seem to be related to this, but can you please take a look? Thanks!

Material-UI: You are trying to override a style that does not exist.
Fix the `&:hover` key of `theme.overrides.MuiDrawer`. 
    at WithStyles (http://localhost:4533/static/js/0.chunk.js:44774:31)
    at Sidebar (http://localhost:4533/static/js/0.chunk.js:135478:24)
    at main
    at div
    at div
    at LayoutWithoutTheme (http://localhost:4533/static/js/0.chunk.js:134273:24)
    at WithStyles (http://localhost:4533/static/js/0.chunk.js:44774:31)
    at C (http://localhost:4533/static/js/0.chunk.js:353348:37)
    at ConnectFunction (http://localhost:4533/static/js/0.chunk.js:350632:75)
    at ThemeProvider (http://localhost:4533/static/js/0.chunk.js:43476:24)
    at Layout (http://localhost:4533/static/js/0.chunk.js:134391:26)
    at div
    at HotKeysWrapper (http://localhost:4533/static/js/0.chunk.js:182510:5)
    at HotKeysEnabled (http://localhost:4533/static/js/0.chunk.js:192231:7)
    at push../src/layout/Layout.js.__webpack_exports__.default (http://localhost:4533/static/js/main.chunk.js:9798:88)
    at Route (http://localhost:4533/static/js/0.chunk.js:353091:29)
    at Switch (http://localhost:4533/static/js/0.chunk.js:353293:29)
    at div
    at CoreAdminRouter (http://localhost:4533/static/js/0.chunk.js:98879:87)
    at Route (http://localhost:4533/static/js/0.chunk.js:353091:29)
    at Switch (http://localhost:4533/static/js/0.chunk.js:353293:29)
    at CoreAdminUI (http://localhost:4533/static/js/0.chunk.js:99095:15)
    at AdminUI
    at Router (http://localhost:4533/static/js/0.chunk.js:352726:30)
    at ConnectedRouter (http://localhost:4533/static/js/0.chunk.js:55978:7)
    at ConnectedRouterWithContext (http://localhost:4533/static/js/0.chunk.js:56101:25)
    at ConnectFunction (http://localhost:4533/static/js/0.chunk.js:350632:75)

@Dnouv
Copy link
Contributor Author

Dnouv commented May 12, 2021

Thanks a lot, @deluan, for the review, and about this error, I will create a PR to fix it.

This was referenced May 12, 2021
Closed
Merged
@github-actions
Copy link

github-actions bot commented Mar 16, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deluan deluan deluan requested changes

Assignees

No one assigned

Labels

frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PWA] status bar doesn't match theme color

2 participants

@Dnouv @deluan