Skip to content

Conversation

@deeeeeebs
Copy link
Contributor

No description provided.

@deluan
Copy link
Member

deluan commented May 21, 2021

Hey @deeeeeebs , thanks for this! I see there are two variants of the language: Swedish and Swedish (FI). I'm assuming the later is for Finland, right? To which one does your translation applies?

Do you want to join the translation project in POEditor? If you want, please join our Discord server, #translations channel.

Copy link
Member

@deluan deluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISO 639-1 code for Swedish is sv: https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=sv

Any reason why you used se?

@deeeeeebs
Copy link
Contributor Author

Hey @deluan!
I'm totally fresh to github so sorry if mistakes are made...

Swedish (FI) is for Finland yeah. This translation is for Swedish and you are absolutely right, the code should be sv and not se. Was about to type sv but for whatever reason, I thought it was se going by earlier projects i've translated years ago and didn't bother to check the ISO standard.

@deluan
Copy link
Member

deluan commented May 21, 2021

No worries. For testing purposes, you can put your translation file in the ${DataFolder}/resources/i18n folder, restart Navidrome and you will be able to select the language after refreshing the browser.

Please check if everything is correct, fix any pending issue if any, including the change from se to sv. Once that's done, I can merge it to master.

@deeeeeebs
Copy link
Contributor Author

deeeeeebs commented May 21, 2021

Tried to look for this earlier before I submitted and sorry if it's a dumb question but where do I find the data folder?

My current install is on Debian buster and there are only 2 folder locations with data in them from what I can tell
/var/lib/navidrome (which only has a cache folder and some database files)
and
/opt/navidrome (which has the navidrome executable, license and readme + the music folder)

Edit: nvm... create folders in /var/lib/navidrome and it's all good! Thanks for the pointer

deeeeeebs added 3 commits May 21, 2021 23:46
Added further lines/translations from the english.json and corrected some of the previous translations
Ok now i'm done! :P
@deluan deluan merged commit 02606f4 into navidrome:master May 24, 2021
@deluan
Copy link
Member

deluan commented May 24, 2021

Thanks! Please consider joining Discord, it is easier to keep translators informed about new terms being introduced.

deluan pushed a commit that referenced this pull request May 24, 2021
* Swedish translation

* Updated and renamed to sv.json

Added further lines/translations from the english.json and corrected some of the previous translations

* Update sv.json

* Update sv.json

Ok now i'm done! :P
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants