Skip to content

fix(server): db migration does not work for MusicFolders ending with a trailing slash. #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deluan merged 2 commits into from
Mar 11, 2025
Merged

fix(server): db migration does not work for MusicFolders ending with a trailing slash. #3797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01614bd
fix(server): db migration was not working for MusicFolders ending wit…
deluan Mar 10, 2025
b803c84
fix(server): db migration for relative paths
deluan Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions db/migrations/20241026183640_support_new_scanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ join library on media_file.library_id = library.id`, string(os.PathSeparator)))
f := model.NewFolder(lib, path)
_, err = stmt.ExecContext(ctx, f.ID, lib.ID, f.Path, f.Name, f.ParentID)
if err != nil {
log.Error("Error writing folder to DB", "path", path, err)
log.Error("error writing folder to DB", "path", path, err)
}
}
return err
Expand All @@ -187,7 +187,12 @@ join library on media_file.library_id = library.id`, string(os.PathSeparator)))
return fmt.Errorf("error populating folder table: %w", err)
}

libPathLen := utf8.RuneCountInString(lib.Path)
// Count the number of characters in the library path
libPath := filepath.Clean(lib.Path)
libPathLen := utf8.RuneCountInString(libPath)

// In one go, update all paths in the media_file table, removing the library path prefix
// and replacing any backslashes with slashes (the path separator used by the io/fs package)
_, err = tx.ExecContext(ctx, fmt.Sprintf(`
update media_file set path = replace(substr(path, %d), '\', '/');`, libPathLen+2))
if err != nil {
Expand Down