cli chmod hack deleted #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Nov 3, 2022
Member
ailisp
left a comment
There was a problem hiding this comment.
Will the packaged near-sdk-js still installing near-sdk-js as executable? Is that because npm/yarn will do that?
Collaborator
Author
|
@ailisp I checked the docs on this, the only thing we need to do is to add it to bin in package.json. TS CLI file does not need to be 755, and the JS CLI file is already 755 and it stays 755 after we make changes to TS one and |
waynenilsen
pushed a commit
to waynenilsen/near-sdk-js
that referenced
this pull request
Nov 10, 2022
* cli chmod hack deleted * cli chmod 755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.