Verify edges only once in a correct way #4149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
approved these changes
Mar 22, 2021
chain/network/src/peer_manager.rs
Outdated
| } | ||
| } | ||
| new_edges.push(edge); | ||
| if start.elapsed() >= Duration::from_millis(50) { |
Collaborator
There was a problem hiding this comment.
can you extract this time duration out as a constant?
2259892 to
50768d5
Compare
50768d5 to
5090ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a corrected version of #4145 which I reverted.
I added a check, to make sure we don't prune edges while they are requests to edge versifier in progress.