feat(rpc): viewing large contract state is now prohibted to avoid excessive resource consumption #4167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
commented
Mar 25, 2021
frol
approved these changes
Mar 25, 2021
khorolets
approved these changes
Mar 26, 2021
frol
approved these changes
Mar 29, 2021
|
|
||
| impl TrieViewer { | ||
| /// Upper bound of the size of contract state that is still viewable. | ||
| const CONTRACT_STATE_SIZE_LIMIT: u64 = 50_000; |
Contributor
There was a problem hiding this comment.
How complicated is it to be exposed via the config.json file, so we can recommend people to run their own RPC node with the limit bumped to the values they feel is necessary?
Collaborator
Author
There was a problem hiding this comment.
The problem is that it is related to the jsonrpc timeout (which is currently hardcoded). We need to refactor that part as well :(
evgenykuzyakov
approved these changes
Mar 29, 2021
SkidanovAlex
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3950.
Test plan
test_view_state_too_large