store: cancel background RocksDB tasks before closing the database #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bowenwang1996
left a comment
There was a problem hiding this comment.
@mina86 looks like the implementation is for feature single_thread_rocksdb, which is not enabled by default.
Contributor
Author
|
D’oh. So now it turns out we need to update rocksdb to 0.16 to get this to work. |
Per RocksDB FAQ: > Q: Is it safe to close RocksDB while another thread is issuing read, > write or manual compaction requests? > A: No. The users of RocksDB need to make sure all functions have > finished before they close RocksDB. You can speed up the waiting > by calling CancelAllBackgroundWork(). Better be safe than sorry so add the call before the rocksdb::DB object is dropped. Issue: near#3266
Collaborator
Let's do that then |
Contributor
Author
|
Yep, already in review queue: #4442 |
bowenwang1996
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RocksDB FAQ:
Better be safe than sorry so add the call before the rocksdb::DB object
is dropped.
Fixes: #3266