Bench improvement #1342
Bench improvement #1342
Conversation
maxzaver
left a comment
There was a problem hiding this comment.
Please add the report itself (including html) so that we can diff it whenever we have a change. Also, exclude the report from the repo stats using gitattributes.
| for i in 1..n + 1 { | ||
| sum += (i * i) as u128; | ||
| } | ||
| sum /= n as u128; |
There was a problem hiding this comment.
Otherwise it overfits u64 for larger sums
| expected_value += (i * i) as u128; | ||
| } | ||
| expected_value /= n as u128; | ||
| group.bench_function(BenchmarkId::new("wasm", benchmark_param_display.clone()), |b| { |
There was a problem hiding this comment.
benchmark id should include name of the function, e.g. "sum_n"?
There was a problem hiding this comment.
the group has the name
|
@evgenykuzyakov Is this an abandoned PR? Should we close it? |
|
Sorry. It still worth to complete it. I just didn't get back to address the changes. Will take a look later this week. |
|
@evgenykuzyakov Did you have a chance to look at it? |
|
@evgenykuzyakov ping? |
|
We can probably close it since now we have |
|
It's also less useful, since it just runs wasm in isolation. |
Switch bencher to criterion. Update sum_n to do work instead of running pre-compiled code