Skip to content

Conversation

@pugachAG
Copy link
Contributor

FastNear reported an issue with IndexerChunkView:

2.10 broke compatibility of old blocks due to introduction of local receipts in the IndexerChunkView. Need to mark them as optional in serde otherwise previous blocks can't be decoded.

@pugachAG pugachAG requested a review from a team as a code owner November 18, 2025 19:06
@pugachAG pugachAG added this pull request to the merge queue Nov 18, 2025
@darioush
Copy link
Contributor

Should we add a unit test as follow-up? To ensure it does not get accidentally changed?

@shreyan-gupta shreyan-gupta removed this pull request from the merge queue due to a manual request Nov 18, 2025
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@shreyan-gupta
Copy link
Contributor

The falkiness in the Large pytest Tests is getting super irritating. Here I am sitting at 2 am in the night baby sitting the merge queue where this one flaky test makes the whole merge queue of multiple PRs run everything again...

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2025
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Nov 19, 2025
Merged via the queue into master with commit 19fab97 Nov 19, 2025
25 checks passed
@shreyan-gupta shreyan-gupta deleted the indexer-local-receipts-default branch November 19, 2025 04:55
PolyProgrammist pushed a commit to PolyProgrammist/nearcore that referenced this pull request Nov 19, 2025
…tibility (near#14634)

FastNear reported an issue with `IndexerChunkView`:
> 2.10 broke compatibility of old blocks due to introduction of local
receipts in the IndexerChunkView. Need to mark them as optional in serde
otherwise previous blocks can't be decoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants