fix: add mutex to LocalRepositoryCache to prevent concurrent map panic#6109
Open
AruneshDwivedi wants to merge 2 commits into
Open
fix: add mutex to LocalRepositoryCache to prevent concurrent map panic#6109AruneshDwivedi wants to merge 2 commits into
AruneshDwivedi wants to merge 2 commits into
Conversation
…l/bin The install script was defaulting to ./bin (relative to current working directory) instead of a proper user bin directory. This caused act to be installed in whatever directory the user happened to be in when running the install script, making it unfindable. Fixes nektos#2519
LocalRepositoryCache.CacheDirCache is a plain map accessed concurrently by Fetch (write) and GetTarArchive (read) when multiple matrix jobs resolve --local-repository actions in parallel. This causes intermittent 'concurrent map read and map write' panics. Add a sync.RWMutex to protect CacheDirCache access: - Write lock in Fetch when storing to CacheDirCache - Read lock in GetTarArchive when reading from CacheDirCache This is the same class of bug as nektos#6028 (fixed in nektos#6029 for GoGitActionCache). Fixes nektos#6057
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
LocalRepositoryCache.CacheDirCache is a plain map accessed concurrently by Fetch (write) and GetTarArchive (read) when multiple matrix jobs resolve --local-repository actions in parallel. This causes intermittent 'concurrent map read and map write' panics.
Root cause
No synchronization on the CacheDirCache map. Same class of bug as #6028 (fixed in #6029 for GoGitActionCache).
What I changed
Fixes #6057